Create execution according to task config #3302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nelson Chen <[email protected]>
Signed-off-by: Nelson Chen <[email protected]>
arbaobao
requested review from
cosmicBboy,
davidmirror-ops,
eapolinario,
kumare3,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3302 +/- ##
==========================================
- Coverage 82.92% 76.49% -6.44%
==========================================
Files 348 218 -130
Lines 28294 22764 -5530
Branches 2969 2971 +2
==========================================
- Hits 23463 17413 -6050
- Misses 3983 4532 +549
+ Partials 848 819 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pingsutw
reviewed
Jul 23, 2025
Signed-off-by: Nelson Chen <[email protected]>
Signed-off-by: Nelson Chen <[email protected]>
arbaobao
force-pushed
the
Add_user_specified_field
branch
from
9c52f5e to
429a47e
Compare
Signed-off-by: Nelson Chen <[email protected]>
Signed-off-by: Nelson Chen <[email protected]>
pingsutw
reviewed
Aug 16, 2025
Signed-off-by: Nelson Chen <[email protected]>
pingsutw
approved these changes
Aug 21, 2025
Atharva1723
pushed a commit
to Atharva1723/flytekit
that referenced
this pull request
Oct 5, 2025
Signed-off-by: Nelson Chen <[email protected]> Signed-off-by: Atharva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
If we specified the project/domain in the flytectl config, flytekit will create to corresponding project/domain
What changes were proposed in this pull request?
If a task configuration is defined in the Flytectl config, it should be used; otherwise, the default settings will be applied.
How was this patch tested?
Add task configuration in flytectl config and create a workflow. It will be create at the specified field.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances task configuration management by integrating user-defined project and domain settings from Flytectl. It improves parameter handling and default value application, streamlining the setup process and correcting documentation discrepancies.